lftp 4.5.0

[Alexander V. Lukyanov]

lftp-4.5.0 has been released. Changes:

* optimized cpu usage for 10Gb/s transfers by using better data structures
and algorithms.
* new open option --env-password to take password from LFTP_PASSWORD
environment variable.
* new `exit parent' subcommand.
* new settings http:accept-encoding, http:decode.
* new setting xfer:max-log-size to limit transfer log size.
* show last disconnect cause for a few seconds in the session status.
* improved mirror status to display real-time aggregated byte count and rate.
* save torrent matadata on disk and load if available when needed.
* improved torrent DHT search.
* fixed exit behavior to flush buffered commands.
* fixed transfer rate reporting for mirror --parallel.

Get it from http://lftp.yar.ru/get.html or your favorite mirror.
Binaries for Fedora 19 are also available.

[Noël Köthe]

Hello Alexander,
I'm trying to build this new version but run into this error:

....
/bin/bash ../libtool --silent --tag=CXX --mode=compile gcc -DHAVE_CONFIG_H -I. -I../lib -I../lib -I../trio -I/usr/include/p11-kit-1 -D_FORTIFY_SOURCE=2 -g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security -g -Wall -Wall -Wwrite-strings -Woverloaded-virtual -fno-exceptions -fno-rtti -fno-implement-inlines -MT SleepJob.lo -MD -MP -MF .deps/SleepJob.Tpo -c -o SleepJob.lo SleepJob.cc
mv -f .deps/SleepJob.Tpo .deps/SleepJob.Plo
/bin/bash ../libtool --silent --tag=CXX --mode=link gcc -g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security -g -Wall -Wall -Wwrite-strings -Woverloaded-virtual -fno-exceptions -fno-rtti -fno-implement-inlines -module -avoid-version -rpath /usr/lib/lftp/4.5.0 -Wl,-z,relro -o cmd-sleep.la SleepJob.lo -lutil -ltinfo -ldl -lsupc++
/bin/bash ../libtool --silent --tag=CXX --mode=compile gcc -DHAVE_CONFIG_H -I. -I../lib -I../lib -I../trio -I/usr/include/p11-kit-1 -D_FORTIFY_SOURCE=2 -g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security -g -Wall -Wall -Wwrite-strings -Woverloaded-virtual -fno-exceptions -fno-rtti -fno-implement-inlines -MT Torrent.lo -MD -MP -MF .deps/Torrent.Tpo -c -o Torrent.lo Torrent.cc
Torrent.cc: In member function 'virtual int TorrentPeer::Do()':
Torrent.cc:2869:69: error: format not a string literal and no format arguments [-Werror=format-security]
LogError(4,dc=_("peer closed connection (before handshake)"));
^
Torrent.cc:2983:50: error: format not a string literal and no format arguments [-Werror=format-security]
LogError(2,dc=_("invalid peer response format"));
^
Torrent.cc: In member function 'void Torrent::SaveMetadata() const':
Torrent.cc:611:32: warning: ignoring return value of 'int ftruncate(int, __off_t)', declared with attribute warn_unused_result [-Wunused-result]
ftruncate(fd,bytes_to_write);
^
cc1plus: some warnings being treated as errors
Makefile:2223: recipe for target 'Torrent.lo' failed
make[2]: *** [Torrent.lo] Error 1
make[2]: Leaving directory '/tmp/buildd/lftp-4.5.0/src'
Makefile:1584: recipe for target 'all-recursive' failed
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory '/tmp/buildd/lftp-4.5.0'

gcc is 4.8.3. Do you need the whole buildlog?

Thanks alot.

Regard

Noël

[Alexander V. Lukyanov]

Post by Noël Köthe
Hello Alexander,
Torrent.cc:2869:69: error: format not a string literal and no format arguments [-Werror=format-security]
LogError(4,dc=_("peer closed connection (before handshake)"));

Nice catch. In fact there was also a logic error which caused %s to stay in
the disconnect cause.

Here is a patch to fix it.

--
Alexander.

[Noël Köthe]

Hello Alexander,

Post by Alexander V. Lukyanov

Post by Noël Köthe
Torrent.cc:2869:69: error: format not a string literal and no format arguments [-Werror=format-security]
LogError(4,dc=_("peer closed connection (before handshake)"));

Nice catch. In fact there was also a logic error which caused %s to stay in
the disconnect cause.
Here is a patch to fix it.

Thanks alot for the very fast answer. Works without problem and lftp
4.5.0 is available in Debian:

https://packages.debian.org/lftp

Regards

Noël